The changes in this PR will prevent situations where a call to TextField::deleteBackward is made for every single character when deleting text in large blocks, such as via a Select All -> Backspace operation using the Android virtual keyboard. When many consecutive calls to deleteBackward are made in a single update/frame, it seems to result in a crash.
Just note that this does not change the behavior when the user is deleting one character at a time, since it will still call TextField::deleteBackward once per character. The test cases in cpp-tests, 49:Node: Text Input confirm that the behaviour is still the same.
Issue ticket number and link
This possibly relates to all the following issues:
2240
2241
2242
Checklist before requesting a review
For each PR
[ ] Add Copyright if it missed:
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
[x] I have performed a self-review of my code.
Optional:
[ ] I have checked readme and add important infos to this PR.
[ ] I have added/adapted some tests too.
For core/new feature PR
[ ] I have checked readme and add important infos to this PR.
Describe your changes
The changes in this PR will prevent situations where a call to
TextField::deleteBackwardis made for every single character when deleting text in large blocks, such as via a Select All -> Backspace operation using the Android virtual keyboard. When many consecutive calls todeleteBackwardare made in a single update/frame, it seems to result in a crash.Just note that this does not change the behavior when the user is deleting one character at a time, since it will still call
TextField::deleteBackwardonce per character. The test cases in cpp-tests,49:Node: Text Inputconfirm that the behaviour is still the same.Issue ticket number and link
This possibly relates to all the following issues:
2240
2241
2242
Checklist before requesting a review
For each PR
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."[x] I have performed a self-review of my code.
Optional:
For core/new feature PR