axmolengine / axmol

Axmol Engine – A Multi-platform Engine for Desktop, XBOX (UWP) and Mobile games. (A fork of Cocos2d-x-4.0)

https://axmol.dev

MIT License

929 stars 205 forks source link

Detect CTRL+A key combination to select all text in EditBox #2251

Closed rh101 closed 1 day ago

rh101 commented 1 day ago

Describe your changes

This is a simpler solution to detecting CTRL+A in order to select all text in the EditBox.

This does not have the side effects present in #2238 and #2246.

Issue ticket number and link

2236

Checklist before requesting a review

For each PR

[ ] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
[x] I have performed a self-review of my code.

Optional:
- [ ] I have checked readme and add important infos to this PR.
- [ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

paulocoutinhox commented 23 hours ago

Hi. Nice feature. It works for macOS? Command + A?

rh101 commented 23 hours ago

Hi. Nice feature. It works for macOS? Command + A?

Does the same issue exist on MacOS? EditBox implementations are specific to the target platform, so the code in this PR has nothing to do with MacOS.