Migrate lua from 5.1~5.3.x to 5.4.x

axmolengine / axmol

Axmol Engine – A Multi-platform Engine for Desktop, XBOX (UWP) and Mobile games. (A fork of Cocos2d-x-4.0)

https://axmol.dev

MIT License

922 stars 205 forks source link

Migrate lua from 5.1~5.3.x to 5.4.x #332

Closed aismann closed 3 years ago

aismann commented 3 years ago

[x] unpack, pack moved from global to package table
[x] math.pow was removed, use operator ^ instead
[x] Use # instead table.getn
[x] Since lua-5.1 math.mod was renamed to math.fmod, the behavior same with operator %
[x] Remove any garbage collection settings in lua code

halx99 commented 3 years ago

I have run the lua-tests project with lua5.4.2, the performance is very slow when scroll the main menu panel, so it may needs a long time to determine whether upgrade to lua5.4.x

halx99 commented 3 years ago

Note: By profile with visualstudio, it may caused by incorrect gc mode set

halx99 commented 3 years ago

Actually, axmol support simply switch plain lua version with follow steps:

unzip lua-5.4.3.tar.gz and copy folder lua-5.4.3 to thirdparty/lua/plainlua/
Add "-DLUA_VERSION=5.4.3" when use cmake to generate project files

halx99 commented 3 years ago

https://eklausmeier.wordpress.com/2020/05/14/performance-comparison-pallene-vs-lua-5-1-5-2-5-3-5-4-vs-c/