axmolengine / axmol

Axmol Engine – A Multi-platform Engine for Desktop, XBOX (UWP) and Mobile games. (A fork of Cocos2d-x-4.0)
https://axmol.dev
MIT License
922 stars 205 forks source link

Migrate engine name, huge changes #724

Closed halx99 closed 2 years ago

halx99 commented 2 years ago

source code

project tools

docs

aismann commented 2 years ago

It is the right way. Great!

aismann commented 2 years ago
  • [ ] Remove source code file name prefix CC, such as CCFileUtils to FileUtils

Maybe prefix AX is better? uch as CCFileUtils to AXFileUtils

halx99 commented 2 years ago

The prefix makes people feel tired.

DelinWorks commented 2 years ago
  • [ ] Remove source code file name prefix CC, such as CCFileUtils to FileUtils

You can add the breaks compatibility label so that people know why their project won't compile!

halx99 commented 2 years ago

I will merge all before any migrate commits to branch release and change github default branch to it.

Certainly, any pull request sitll and always been want merge to branch dev

Because these changes too huge, let's put to next prerelease 1.0.0b9

DelinWorks commented 2 years ago

Should we replace every source file that contains cocos2d with axis?

aismann commented 2 years ago

Should we replace every source file that contains cocos2d with axis?

I think ax:: is the namespace?

DelinWorks commented 2 years ago

No I mean like there are comments that contain the word cocos2d should we replace them? The namespaces can be ax:: though

halx99 commented 2 years ago

Should we replace every source file that contains cocos2d with axis?

Yes

aismann commented 2 years ago

Maybe a new PR?

halx99 commented 2 years ago

Maybe a new PR?

Yes, needs seperate PR

DelinWorks commented 2 years ago

@halx99 should this be replaced with ax or axis?

image

halx99 commented 2 years ago

@halx99 should this be replaced with ax or axis?

image

Yes, both axis or ax is ok for me, so maybe the original namespace is axis, then ax is abbv of it.

DelinWorks commented 2 years ago

yeah, and then we can use axis as the main namespace and then shorten it with namespace ax = ::axis;

DelinWorks commented 2 years ago

@halx99 @aismann would this be a nice logo?

image

And the mini logo can be:

image

props to @aismann it was his idea #722

aismann commented 2 years ago

Looks good. I will make small changes later (only an example). image

halx99 commented 2 years ago

Maybe the coord lines could be looks like perspective 15/30/45 degree

DelinWorks commented 2 years ago

Looks good. I will make small changes later (only an example). image

image

I changed my mind it looks better now

DelinWorks commented 2 years ago

Maybe the coord lines could be looks like perspective 15/30/45 degree

It doesn't look right with the 3D look :/

aismann commented 2 years ago

Looks good. I will make small changes later (only an example). image

image

I changed my mind it looks better now

Can you make an example with an lowercase i like: AXiS

aismann commented 2 years ago

Looks good. I will make small changes later (only an example). image

image

I changed my mind it looks better now

Can you make an example with an lowercase i like: AXiS

DelinWorks commented 2 years ago

image

aismann commented 2 years ago

image

Thanks. Looks not so good, or?

DelinWorks commented 2 years ago

you mean the lowercase i or the whole design?

aismann commented 2 years ago

The wohl desing is good. As longer I see the AXiS as more I like the lowercase i

DelinWorks commented 2 years ago

Do you mean closer?

Like this:

image

image

aismann commented 2 years ago

Closer looks better.

aismann commented 2 years ago

@DelinWorks Can you make the blue darker? Maby only the 5 lines in the middle?

DelinWorks commented 2 years ago

which one? the one with the lowercase i?

aismann commented 2 years ago

Yes. Only one is enough to see the look of the darker blue line. Please also on the Icon. I belive the darker blue line Looks better.

aismann commented 2 years ago

image Should we coloring the dot too (or let the 'i' uppercase or uncolored)? maybe the blue border is to brightness

DelinWorks commented 2 years ago

No because when you look at an editor like blender you'll notice that the axis lines are green red blue so I see no point in adding yellow in i there

image

DelinWorks commented 2 years ago

image

aismann commented 2 years ago

I like it! I have no problem to write AXIS, axis, or AXiS, but the logo should having this lowercase "i". Sources should have only lowercase or ax

DelinWorks commented 2 years ago

I think this looks better because mixed lowercase and uppercase letters look a bit weird

image

aismann commented 2 years ago

Also ok

DelinWorks commented 2 years ago

okay @halx99 what do you think?

The logos are:

image

and the mini logo, I tried making it 3D but no matter what it just looks a bit off

image

halx99 commented 2 years ago

This draft is my idea: 16577518301606701110973421307530

DelinWorks commented 2 years ago

😮

DelinWorks commented 2 years ago

two designs that came up with idea

image

image

What do you think? of course It will be polished after it's chosen

halx99 commented 2 years ago

I means reuse the longest line for A,X and S(if possible)

DelinWorks commented 2 years ago

Sorry I can't understand 😅 could you elaborate?

DelinWorks commented 2 years ago

Untitled.zip

Here is the Paint.net PDN file, tweak it based on your liking

halx99 commented 2 years ago

How can I open the .pdn file?

DelinWorks commented 2 years ago

download Paint.net

halx99 commented 2 years ago

IMG_20220714_111441

DelinWorks commented 2 years ago

>

😕 it looks a bit wanky and doesn't go with the axis xyz style, it looks like a frills design rather than a good straight forward design

aismann commented 2 years ago

macros: CC to AX Remove source code file name prefix CC, such as CCFileUtils to FileUtils

I approve: Replace CC with AX on the file name (like the macros). look here as an example: why: Without the 'CC' or new: 'AX' as an 'information on the filename, developer lose the information which 'kind of package' it is. (cp = Chipmunk2D, CC=Cocos2D) And last but not least: The AX'filename' is also a namespace definition. Better remove the CC with AX such as CCFileUtils to AXFileUtils

image

halx99 commented 2 years ago

All in axis/core should be engine package

aismann commented 2 years ago

All in axis/core should be engine package

@halx99 cpCompat62.h has no CC and it is part of the core. What will you doing here?