aylei / kubectl-debug

This repository is no longer maintained, please checkout https://github.com/JamesTGrant/kubectl-debug.
Apache License 2.0
2.31k stars 303 forks source link

Fix the broken registry secret configuration and examples in the README #130

Closed atheriel closed 4 years ago

atheriel commented 4 years ago

The configuration actually requires registrySecretName and registrySecretNamespace, not their uppercased counterparts.

I think this might be the underlying cause of #89.

Also, the example for creating a secret does not work at all -- the resulting secret has the key registrySecret.txt and an invalid JSON payload. I created a working example to remedy this.