ayn2op / discordo

A lightweight, secure, and feature-rich Discord terminal client.
MIT License
2.19k stars 69 forks source link

desktop notifications via dbus or beeep #240

Closed apprehensions closed 2 years ago

apprehensions commented 2 years ago

https://github.com/ayntgl/discordo/issues/121 was mainly referencing dunst, which it's only possible way to communicate to with notifiactions is with dbus, and with the beeep library it should be straight-forward i'd assume.

tl;dr use beeep as it can support dbus, which means native system notifictations.

alternatively; have a FIFO/file for discordo to put notifiactions into, which can be read by a wrapper to send to a notification handler (eg. herbe, xnotify, dunst (without dbus!))

ghost commented 2 years ago

For cross-compatibility, beeep is a better choice since it supports all major platforms, while dbus is limited to Linux.

apprehensions commented 2 years ago

after looking at strace it doesn't seem to even attempt to send a notification

apprehensions commented 2 years ago
method call time=1665943865.546995 sender=:1.366 -> destination=org.freedesktop.DBus serial=1 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=Hello
method return time=1665943865.547006 sender=org.freedesktop.DBus -> destination=:1.366 serial=1 reply_serial=1
   string ":1.366"
signal time=1665943865.547013 sender=org.freedesktop.DBus -> destination=(null destination) serial=483 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameOwnerChanged
   string ":1.366"
   string ""
   string ":1.366"
signal time=1665943865.547022 sender=org.freedesktop.DBus -> destination=:1.366 serial=2 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameAcquired
   string ":1.366"

it does acquire dbus however

029A-h commented 2 years ago

As far as I understand on Jan 25 beeep notification was removed from application. COMMIT: refactor: remove notifications feature

What is current status of notification feature? Is it still fully removed or does it works anyhow on linux? I'm asking because in that case the app is moreless useless for my need. README.md contains desktop notification among features.

apprehensions commented 1 year ago

i still dont get notifications