azavea / climate-change-lab

Other
4 stars 1 forks source link

Add form validation feedback #243

Open flibbertigibbet opened 7 years ago

flibbertigibbet commented 7 years ago

If a user enters invalid data in a parameters control form, the chart simply fails to reload.

Provide feedback, either as text or with a red border to the form control, or both, so the user may see that the form is invalid.

See #230.

jfrankl commented 7 years ago

@flibbertigibbet I am trying to understand this issue better. Could you give me 2–3 examples of invalid input? For each:

flibbertigibbet commented 7 years ago

As with #230:

jfrankl commented 7 years ago

Does something like this work?

image

fungjj92 commented 7 years ago

I think that's a great visual

CloudNiner commented 7 years ago

Does the red error text fill existing empty space, such that all the components below it don't shift down when the error displays? Otherwise agreed, looks great.

jfrankl commented 7 years ago

@CloudNiner What do you think of something like this, so we don't need to worry about the error message pushing down other content?

image

CloudNiner commented 7 years ago

That seems good too, as long as the white text on red is readable. It feels very thin but that may just be the screenshot.

maurizi commented 5 years ago

Styling for error popovers was added in https://github.com/azavea/climate-change-lab/pull/342, but we should still add validation to the rest of the controls