Fix chart display on Safari

azavea / climate-change-lab

Other

4 stars 1 forks source link

Fix chart display on Safari #310

Closed maurizi closed 6 years ago

maurizi commented 7 years ago

Overview

Charts were not appearing because the flexbox-based layout was giving the chart and some of its child elements 0 height.

Switching to absolutely positioned elements for some items seems to be be more well supported, and did not seem to cause any regressions on other browsers.

Testing Instructions

yarn run serve
Charts should be properly sized and visible on all supported browsers

Checklist

[x] yarn run serve clean?
[x] yarn run build:prod clean?
[x] yarn run lint clean?

Fixes #244 Fixes #304

flibbertigibbet commented 6 years ago

Due to #314, haven't tested charts display on some browser combinations

jfrankl commented 6 years ago

Charts were not appearing on any browsers?

flibbertigibbet commented 6 years ago

Couldn't get far enough to check out charts on other browsers, because I couldn't get past the login while running the lab locally.

maurizi commented 6 years ago

The login page has been removed from the Lab, so I think it's okay if this breaks login page styling. Can you try rebasing this branch on top of the latest develop branch and retesting?

flibbertigibbet commented 6 years ago

Yes, that sorts it out. I'll go ahead and push the rebase, in case anyone else wants to check it out today.

maurizi commented 6 years ago

@jfrankl:

Charts were not appearing on any browsers?

Charts were not appearing in Safari, but were in other browsers