azavea / climate-change-lab

Other
4 stars 1 forks source link

Lab tweaks for Prep Demo #323

Closed CloudNiner closed 6 years ago

CloudNiner commented 6 years ago

Overview

Two small changes to the Lab in preparation for the Prep demo on Wednesday.

  1. Download both the future and historical API calls when downloading JSON.
  2. Highlight the currently active Indicator in the sidebar

Demo

screen shot 2017-11-27 at 15 03 02

Testing Instructions

Ensure the currently active indicator is highlighted in blue both when you choose a new indicator as well as when the app initially loads.

Ensure that you get both the Historical and Future JSON files when you click the "Download JSON" button. Some browsers will require user interaction to verify that downloading multiple files is OK.

Checklist

fungjj92 commented 6 years ago
screen shot 2017-11-28 at 9 16 55 am

Active indicator looks like this on Chrome. I ~don't~ actually kinda like it, for emphasis, but it's the odd ball out (among Chrome, FF, and Safari. IDK about the rest). indicator:hover is sticky upon click in Chrome, which has the outline CSS property. If you add outline: none to indicator.active then it goes away. Change not tested in other browsers.

fungjj92 commented 6 years ago

Otherwise LGTM

CloudNiner commented 6 years ago

Looks like outline only shows in Chrome. outline:none works as expected and cleans it up. Looks good in Chrome/FF/Safari.

CloudNiner commented 6 years ago

Updated.