applied feedbacks from @jeonghoyeo7 's code-reveiw
DoLiquidStake must returns total new shares and total ls token mint amount because user can liquid stake multiple chunks.
add sanity checks
use sdk.Int instead of int64 when calc chunksToLiquidUnstake to avoid un-expected overflow error.
avoid division by zero
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
[x] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] included the necessary unit and integration tests
[x] reviewed "Files changed" and left comments if necessary
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
[ ] confirmed all author checklist items have been addressed
Description
applied feedbacks from @jeonghoyeo7 's code-reveiw
DoLiquidStake
must returns total new shares and total ls token mint amount because user can liquid stake multiple chunks.chunksToLiquidUnstake
to avoid un-expected overflow error.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...