b-harvest / Canto

GNU Lesser General Public License v3.0
3 stars 4 forks source link

refactor: Remove RandomizedParams from AppModuleSimulation interface #61

Closed poorphd closed 3 months ago

poorphd commented 4 months ago

Description

RandomizedParams has been removed from the AppModuleSimulation interface. Previously, it generated random parameter changes during simulations through ParamChangeProposal, which is now legacy. Since all modules have been migrated away from using ParamChangeProposal, we can now safely remove RandomizedParams from the interface.

Adding simulation (including MsgUpdateParams proposal) will be added in a separated PR,

Closes: L-2, L-7


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

poorphd commented 3 months ago

simulation for other canto modules are in a separated PR https://github.com/b-harvest/Canto/pull/65

dudong2 commented 3 months ago

IMO it looks good to merge this PR with pr-65, as modifications to the x/coinswap are also being made on pr-65, which causes confusion.