b-harvest / Canto

GNU Lesser General Public License v3.0
3 stars 4 forks source link

fix: Incorrect amino names provided in RegisterConcrete #80

Closed poorphd closed 1 month ago

poorphd commented 1 month ago

Description

Closes: https://github.com/code-423n4/2024-05-canto-findings/issues/2


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

dudong2 commented 1 month ago

If the amino name is longer than 40 characters, there will be problems signing the ledger. For this reason, even in the cosmos-sdk, most msgs are registered in the form of cosmos-sdk/Msg..., except for those that need to be added in common for multiple modules, such as MsgUpdateParams. I think aligning with this convention is the right way to go, so I don't think this pr should be applied.

ref. https://github.com/cosmos/cosmos-sdk/issues/10870