search

b-it-bots / mas_industrial_robotics

MAS Industrial Robotics
https://b-it-bots.readthedocs.io
27 stars 53 forks source link

[PyLinting] Fix pylint errors in python files #148

Open iswariyam opened 4 years ago

iswariyam commented 4 years ago

Most of the python code in the repo is not linted as per PEP8 guidelines. The average rating given by pylint for the various modules is around 3/10. The list of pylint errors can be found here The errors need to be fixed manually.

iswariyam commented 4 years ago

It would be great if we could split the modules among different team members and fix the errors. This would then allow me to incorporate the pylint check in the pre-commit hooks mentioned here #147

iswariyam commented 4 years ago

@deebuls Here are the list of packages throwing pylint errors.

  1. 'mir_calibration/mir_kinect_calibration',
  2. 'mir_manipulation/mir_arm_relative_motion_control',
  3. 'mir_manipulation/mir_grasp_monitors',
  4. 'mir_manipulation/mir_gripper_controller',
  5. 'mir_manipulation/mir_moveit_scene',
  6. 'mir_manipulation/mir_pregrasp_planning',
  7. 'mir_navigation/mir_2dnav',
  8. 'mir_navigation/mir_base_placement',
  9. 'mir_navigation/mir_closed_loop_pick_base_controller',
  10. 'mir_navigation/mir_move_base',
  11. 'mir_navigation/mir_workspace_alignment',
  12. 'mir_perception/mir_perceive_aruco_cube',
  13. 'mir_planning/mir_actions/mir_insert_cavity',
  14. 'mir_planning/mir_actions/mir_insert_object',
  15. 'mir_planning/mir_actions/mir_manipulate_drawer',
  16. 'mir_planning/mir_actions/mir_move_base_safe',
  17. 'mir_planning/mir_actions/mir_perceive_cavity',
  18. 'mir_planning/mir_actions/mir_perceive_drawer',
  19. 'mir_planning/mir_actions/mir_perceive_location',
  20. 'mir_planning/mir_actions/mir_perceive_mock',
  21. 'mir_planning/mir_actions/mir_pick_from_drawer',
  22. 'mir_planning/mir_actions/mir_pick_from_shelf',
  23. 'mir_planning/mir_actions/mir_pick_object',
  24. 'mir_planning/mir_actions/mir_place_object',
  25. 'mir_planning/mir_actions/mir_stage_object',
  26. 'mir_planning/mir_actions/mir_unstage_object',
  27. 'mir_planning/mir_knowledge',
  28. 'mir_planning/mir_knowledge_base_analyzer',
  29. 'mir_planning/mir_planner_executor',
  30. 'mir_planning/mir_planning_core',
  31. 'mir_planning/mir_planning_visualisation',
  32. 'mir_planning/mir_refbox_parser',
  33. 'mir_planning/mir_task_planning',
  34. 'mir_scenarios/mir_basic_manipulation_test',
  35. 'mir_scenarios/mir_basic_navigation_test',
  36. 'mir_scenarios/mir_basic_transportation_test',
  37. 'mir_scenarios/mir_conveyor_belt_test',
  38. 'mir_scenarios/mir_insert_in_container_functionality',
  39. 'mir_scenarios/mir_manipulation_functionality',
  40. 'mir_scenarios/mir_object_perception_functionality',
  41. 'mir_scenarios/mir_place_functionality',
  42. 'mir_scenarios/mir_precision_placement_test',
  43. 'mir_scenarios/mir_states',
  44. 'mir_simulation/mir_world_generation'