search

b13 / menus

TYPO3 Extension for creating fast menus in a fast fashion
GNU General Public License v2.0
54 stars 22 forks source link

Bug: LanguageMenu excludes "nav_hide" pages #38

Closed infabo closed 3 years ago

infabo commented 3 years ago

LanguageMenu should not exclude "nav_hide" pages as this is against the use-case. It makes so sense to adhere this page-attribute in a language-menu context.

see https://github.com/b13/menus/blob/58bd79833c5555f0b17ae9b492b0f831db494b3a/Classes/Compiler/LanguageMenuCompiler.php#L47

and escpecially https://github.com/b13/menus/blob/58bd79833c5555f0b17ae9b492b0f831db494b3a/Classes/Domain/Repository/MenuRepository.php#L81

josefglatz commented 3 years ago

@bmack What do you think? I can create a PR

bmack commented 3 years ago

@josefglatz yes please.

achimfritz commented 3 years ago

is this not already fixed with https://github.com/b13/menus/commit/a746bf269e41719f024a475d81a4617b1b81969b ?

josefglatz commented 3 years ago

is this not already fixed with https://github.com/b13/menus/commit/a746bf269e41719f024a475d81a4617b1b81969b ?

Ah have to check first! Thank you

bmack commented 3 years ago

Looks like this is solved