Closed ftm closed 7 years ago
Thank you for the pull request! This is great! Maybe (just maybe), the package load time will speed up a bit, as the style file doesn't need to be fetched from the disk any longer!
You're welcome, if you're looking to speed up load time it might be better to just delete the
.less
file so it's not trying to load an empty file
Sure thing. I deleted both the less file and the one for the keybinding, as they were useless. I will check with timecop if something changes.
I've added the
inline-block
class to the main clock element so it is displayed in the same as the built in packages on the status bar, removing the need for the extra CSS. I also changed the layout of the elements as can be seen below.Before:
After:
With the new layout, the
icon
class is no longer being applied to thespan
displaying the time so the time no longer moves when the icon is enabled due to themargin-right
from the icon class as can be seen below. I've also refactored the specs to take the new element layout into accountBefore, see how the time moves to the left slightly:
After, see how the time stays still: