search

backdrop-contrib / github_stats

Track Github statistics of Backdrop CMS projects and display in a Views listing.
https://backdropcms.org/project/github_stats
GNU General Public License v3.0
2 stars 1 forks source link

Either validate github_path before saving or allow edit #2

Closed yorkshire-pudding closed 1 month ago

yorkshire-pudding commented 1 month ago

I accidentally typed the github path wrong (including underscores where there were none). It shows an error but the path can't be edited, so you have to delete the entity and recreate.

I ended up hacking the module to allow edit of github path.

indigoxela commented 1 month ago

... can't be edited, so you have to delete the entity and recreate.

That's actually by intention. If you change the path, you might end up with nonsense data (fetched data from other repo).

Validation it is...

ended up hacking the module to allow edit of github path.

Nasty you. :laughing:

Here's a PR that adds more validation before saving: #3

yorkshire-pudding commented 1 month ago

Nasty you. 😆

😆

PR tested and works a treat. Thank you!