search

backdrop-contrib / tocbot

Builds a table of contents (TOC) from content headings.
GNU General Public License v2.0
2 stars 2 forks source link

Update library version #49

Closed laryn closed 11 months ago

laryn commented 11 months ago

I couldn't tell which version of the library was bundled, but it looks like the library is being updated/maintained, so it would be good to update it here (and indicate which version is bundled).

olafgrabienski commented 11 months ago

The bundled version might be 4.8.1, at least it was mentioned as CDN version when the library was bundled into the module. If I don't miss anything, the library wasn't updated after that.

@laryn There are many changes in the library. I guess I can't evaluate them really. What do you think: is it likely that the library update breaks anything?

laryn commented 11 months ago

I don't even see 4.8.1 in the list of releases, and don't see anything called out as a breaking change since then.

olafgrabienski commented 11 months ago

I don't even see 4.8.1 in the list of releases ...

Yep, it wasn't a release, you can see it on this Tags page.

Do you mind providing a pull request?

laryn commented 11 months ago

Sure.

olafgrabienski commented 11 months ago

Thank you very much! I hope to test the PR one of the next days.

olafgrabienski commented 11 months ago

I've applied the PR to a test site. Tocbot works fine, and the appearance of the table of contents didn't change. Works for me!

olafgrabienski commented 11 months ago

I've merged the PR by @laryn. Thanks again for providing the PR!