balancer / backend

MIT License
18 stars 8 forks source link

poolGetAggregatorPools - new fields #979

Open johngrantuk opened 2 weeks ago

johngrantuk commented 2 weeks ago

Could we get the following fields added to the poolGetAggregatorPools:

franzns commented 1 week ago

also add totalSupply and bptPrice as alternatives to totalShares and sharePrice because they seem to be confusing

franzns commented 1 week ago

Could we get the following fields added to the poolGetAggregatorPools:

  • Also need a way to filter certain pool/hooks that may not support swaps so hook config and PoolConfig would be super helpful.

Should we already filter these pools out in the response?

johngrantuk commented 1 week ago

Could we get the following fields added to the poolGetAggregatorPools:

  • Also need a way to filter certain pool/hooks that may not support swaps so hook config and PoolConfig would be super helpful.

Should we already filter these pools out in the response?

I think it would be pretty useful to already filter out pools that have swaps paused. For pools with hooks - as well as having the hook/pool config would it be possible to somehow make it possible to query with something like where: { hasHook: false }? That way its easy to start integrating pools that don't have the added complexity of hooks.

franzns commented 1 week ago

I think it would be pretty useful to already filter out pools that have swaps paused.

Alright, we can filter that.

For pools with hooks - as well as having the hook/pool config would it be possible to somehow make it possible to query with something like where: { hasHook: false }? That way its easy to start integrating pools that don't have the added complexity of hooks.

We can add some sort of filter for hooks, that works. What exactly do you need from the pool config? We already sync certain fields, can you tell me which ones you are missing?

johngrantuk commented 1 week ago

I think it would be pretty useful to already filter out pools that have swaps paused.

Alright, we can filter that.

For pools with hooks - as well as having the hook/pool config would it be possible to somehow make it possible to query with something like where: { hasHook: false }? That way its easy to start integrating pools that don't have the added complexity of hooks.

We can add some sort of filter for hooks, that works. What exactly do you need from the pool config? We already sync certain fields, can you tell me which ones you are missing?

Thanks!

In pool config the following LiquidityManagement is most useful as it potentialy causes issues with add/remove paths:

struct LiquidityManagement {
    bool disableUnbalancedLiquidity;
    bool enableAddLiquidityCustom;
    bool enableRemoveLiquidityCustom;
}
franzns commented 6 days ago

Filters, hook data and liquidity management data is available now

Asked Fabio about scalingFactor support from subgraph as this is immutable