Travelify Demo on Hugo website contains 3rd party tracking

balaramadurai / hugo-travelify-theme

Port of Aigars Silkalns's Wordpress theme Travelify to Hugo. Demo -

http://balaramadurai.github.io

MIT License

40 stars 27 forks source link

Travelify Demo on Hugo website contains 3rd party tracking #25

Closed onedrawingperday closed 5 years ago

onedrawingperday commented 5 years ago

Hello @balaramadurai

I am one of the maintainers of the Hugo Themes repository.

Recently I audited the Hugo Themes website and it has come to my attention that your theme's demo has third party tracking enabled.

     \hugo-travelify-theme\exampleSite\config.toml:
        GoogleAnalytics = "UA-68204765-1"

To fix this issue please leave the above parameter blank i.e.

     \hugo-travelify-theme\exampleSite\config.toml:
        GoogleAnalytics = ""

Once you look into this please let me know.

Thank you!

balaramadurai commented 5 years ago

Hello @onedrawingperday Thank you for raising this issue. Yes, this is definitely an oversight on my part. I have removed the dummy GA code from the code in this commit - ee1b269

Please do let me know if this satisfies the need of the Hugo Themes website.

Thanks and have a great day! Bala

onedrawingperday commented 5 years ago

@balaramadurai

Thank you for the fix! 👍

pidgeontower commented 5 years ago

@onedrawingperday Google Analytics removed as requested.