search

balena-io-experimental / edge-node-manager

Resin uC edge-node-manager written in Go
Apache License 2.0
22 stars 6 forks source link

Implement avahi/mdns discovery #185

Closed jbaldwinroberts closed 7 years ago

jbaldwinroberts commented 7 years ago

Change-type: major

Implement avahi/mdns discovery, this removes the nmap dependency and fixes an issue where every so often nmap would fail to find dependent devices causing them to be marked as offline

jbaldwinroberts commented 7 years ago

@mccollam this is meant to be used on the hotspot network running on the gateway device. We could have an env var to let the user fall back to nmap if they needed to for whatever reason?

mccollam commented 7 years ago

Seems like it is a "nice to have" rather than strictly necessary. I suspect we'll hit Avahi being blocked in the same environment that you're working on this fix for :) But we can certainly try this out and see.

jbaldwinroberts commented 7 years ago

@mccollam avahi won't be blocked as the hotspot network is running the rpi... or am I missing something here?

I will add the nmap scan back in as an option.

mccollam commented 7 years ago

Ah, good point... you're right. Not sure nmap is needed then tbh.

jbaldwinroberts commented 7 years ago

Sweet, thanks dude.