Add specific chromium path when running on alpine

balena-io-modules / scrutinizer

Extract a git repository's metadata relying on open source conventions

Apache License 2.0

8 stars 0 forks source link

Closed nazrhom closed 4 years ago

nazrhom commented 4 years ago

Change-type: patch Signed-off-by: Giovanni Garufi giovanni@balena.io

dimitrisnl commented 4 years ago

It seems strange to me that we have to update our source code, to make CI happy. Any thoughts @jviotti ?

I mean I'm definitely up for it if it solves our issues but I can't help to think there must be something better. We're hardcoding a path here.

nazrhom commented 4 years ago

@dimitrisnl its recommended in https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-on-alpine I guess the reason is that it must use chromium rather than chrome on alpine. We could change it so it runs in a different CI env but this felt like the better fix