test: Update expects for tests

statnmap commented 1 year ago

tags: test

Why?

Need to store expected outputs as easy as possible in tests or inst/

What?

Detect if we are in flat file or in test directory
Update directly were needed if (Sys.getenv("FISHMAP_UPDATE_TEST_OUTPUTS") == "TRUE")
Define only two cases: "small" and "big", so that we can changes default values, not only for k

issue #51

Does my code meet the quality standards for release packages?
Does the reviewer have all the information to validate the features/issues without too much research?
Does the customer who will validate the associated tickets have the information to do so without wasting time?

Issues to validate to close :

[ ] issue #

Processed issues to keep open or in progress:

[ ] issue #

Checklist:

[ ] Does the package check works locally?
[ ] Does the CI pass?
[ ] Are the added / fixed features documented, tested?
[ ] Are the added features / solved problems briefly presented in the PR message?
[ ] Are the changes related to tickets / issues that I have listed in the commits and in the PR itself?
[ ] Are the tickets in "review" mode in the Project Tracking Board?
[ ] Does each ticket, if it is to be closed after acceptance of the PR, contain a comment that tells how to validate it?

codecov[bot] commented 1 year ago

Codecov Report

Merging #54 (db48f7c) into main (c176295) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   64.43%   64.43%           
=======================================
  Files           4        4           
  Lines         537      537           
=======================================
  Hits          346      346           
  Misses        191      191

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

statnmap commented 1 year ago

Used in https://github.com/balglave/FishMap/issues/55 and https://github.com/balglave/FishMap/issues/56

balglave / FishMap

test: Update expects for tests #54

Issues to validate to close :

Processed issues to keep open or in progress:

Checklist:

Codecov Report