As dev, I would like to have a function for executing the code from shape_vmslogbook_data_st.R in the fm_load_data() function so that I can test the part inside this source file.
Client - Validation
[x] Have a function that replace source(file.path(script_folder,"shape_vmslogbook_data_st.R"), local=TRUE)
[x] Run tests on saved outputs to ensure that we have obtained the same results for fm_load_data() for runs with source or function calls
executing locally tests/testthat/test-fm_shape_vms_logbook_data_st.R completes successfully :
(warnings correspond to the Discarded xx unknown in Proj4 definition due to the use of the old package {raster}, cf closed issue 7)
executing CI pipeline completes successfully :
Dev - Tech
[x] make a function for source(file.path(script_folder,"shape_vmslogbook_data_st.R"), local=TRUE) in the flat of fm_load_data
[x] do not export the function as it is only internally used by fm_load_data()
[ ] ~implement the parameters with @inheritParams fm_load_data~ -> no shared params with fm_load_data()
[x] return the output necessary for fm_load_data() as a named list
As dev, I would like to have a function for executing the code from
shape_vmslogbook_data_st.R
in thefm_load_data()
function so that I can test the part inside this source file.Client - Validation
source(file.path(script_folder,"shape_vmslogbook_data_st.R"), local=TRUE)
=> https://github.com/balglave/FishMap/blob/main/R/fm_load_data.R
(no params are inherited from
fm_load_data()
)=> https://github.com/balglave/FishMap/blob/main/R/fm_shape_vms_logbook_data_st.R
=> https://app.codecov.io/gh/balglave/FishMap/blob/main/R/fm_shape_vms_logbook_data_st.R
[x] Run tests on saved outputs to ensure that we have obtained the same results for
fm_load_data()
for runs with source or function callsexecuting locally
tests/testthat/test-fm_shape_vms_logbook_data_st.R
completes successfully : (warnings correspond to theDiscarded xx unknown in Proj4 definition
due to the use of the old package {raster}, cf closed issue 7)executing CI pipeline completes successfully :
Dev - Tech
source(file.path(script_folder,"shape_vmslogbook_data_st.R"), local=TRUE)
in the flat offm_load_data
fm_load_data()
@inheritParams fm_load_data
~ -> no shared params withfm_load_data()
fm_load_data()
as a named list