search

baltimorecounty / BCPL-assets

Client side assets for the Baltimore County Public Library website
4 stars 0 forks source link

Move All Fonts to Sass Variables #132

Open martypowell opened 6 years ago

binyamin commented 5 years ago

@martypowell can i work on this?

martypowell commented 5 years ago

@martypowell can i work on this?

@b3u I'll have to get back to you, this issue is very old, and I still need to verify it. Will get back to you later today.

martypowell commented 5 years ago

@b3u just noticed, that i never got back to you, ill follow up within the hour.

martypowell commented 5 years ago

@b3u looks like this is still valid. The fonts can go in this file.

Please use a hyphenation in the variable names. for example:

'TTRoundsCondensed-BlackItalic' would be $TTRoundsCondensed-BlackItalic.

Once the variables are created, the next task would be to replace any string font family values with those variables.

An example would be here:

https://github.com/baltimorecounty/BCPL-assets/blob/a82e033fe18439833e867c78f238a94e2a357469/stylesheets/partials/units/_typography.scss#L3

Changing to 'Open Sans', Arial, Helvetica, sans-serif; to use a newly created font variable $default-body-font.

Sorry, I know this is a very tedious task, if you any questions, please let me know.

FYI @tmccoy529

binyamin commented 5 years ago

Does FontAwesome become a variable as well?

martypowell commented 5 years ago

Does FontAwesome become a variable as well?

Yes, I think that's a good idea as least for now. Unless you have a better suggestion?

binyamin commented 5 years ago

k