search

baltimorecounty / BCPL-assets

Client side assets for the Baltimore County Public Library website
4 stars 0 forks source link

When selecting the search button, the cursor should automatically appear in the search box #606

Open danfox01 opened 6 years ago

danfox01 commented 6 years ago

Currently, if you click the search button, you have to click again inside the search input. Ideally the cursor should automatically appear inside the input as soon as search is selected. This behavior should also occur when switching between tabs.

sgrg1 commented 5 years ago

Issue fixed, waiting it to move to dev for further testing.

tmccoy529 commented 5 years ago

@danfox01 This is ready for testing

danfox01 commented 5 years ago

Thanks! We can probably complete testing today.

Meanwhile -- it just occurred to me that this functionality will also need to be replicated in the Polaris version of the search. I don't recall if Polaris hits SE code for this feature, or if it needs to be releases there as well. Please advise if a separate issue is needed.

danfox01 commented 5 years ago

@jdomasky can you please test this today? We should run the search test plan and also do a 1:1 comparison against prod for accessibility and keyboard nav. Thanks!

jdomasky commented 5 years ago

No problem. I should be able to start testing between noon and 1:00.

jdomasky commented 5 years ago

@danfox01 @tmccoy529 @martypowell Testing of this issue is complete. In dev, the Search box passed the Search Test Plan, using IE. My 1:1 comparison against prod, using both Edge and Chrome, showed no differences between dev and prod for accessibility and keyboard nav. Spot checks were made in BrowserStack on iPhone 6S Safari. Testing was a success!

danfox01 commented 5 years ago

Thanks! On our end, this is good to release. @tmccoy529 @martypowell please see my question above about how to handle getting this same behavior into the Polaris nav as well. I don't remember if the code is shared.

martypowell commented 5 years ago

@danfox01 bcpl.info and polaris share the the same JavaScript file where these changes were made.