baltimorecounty / BCPL-assets

Client side assets for the Baltimore County Public Library website
4 stars 0 forks source link

Hf contact buttons #623

Closed martypowell closed 5 years ago

martypowell commented 5 years ago

addresses #621

@danfox01 @tmccoy529 fyi

danfox01 commented 5 years ago

Thanks guys! When you are ready, we just need to get this into dev so I can have Jason bang on it for awhile.

martypowell commented 5 years ago

@danfox01 i think this is in dev?

danfox01 commented 5 years ago

OK... can you please let me know for sure and we can commence with the hammering.

martypowell commented 5 years ago

@danfox01 will do.

tmccoy529 commented 5 years ago

Fixed a style issue with the button displaying a shadow when you clicked it. May need to be reviewed though it doesn't appear to be requesting it.

@martypowell

tmccoy529 commented 5 years ago

@danfox01 Marty and I have moved these changes to dev and they are ready to be tested.

jdomasky commented 5 years ago

@tmccoy529 @martypowell @danfox01 The page passed the Locations Page Test Plan. I performed additional testing and discovered one issue: at the bottom of the page, if you toggle on high contrast mode, the contact buttons become misaligned and they don't change color. Recommendation: update the high-contrast stylesheet.

tmccoy529 commented 5 years ago

@jdomasky @martypowell @ danfox01 I had not moved over the high contrast file to SE. This has been moved and ready for retest.

jdomasky commented 5 years ago

Thanks, @tmccoy529. Retesting went well. Everything looks great now! @martypowell @danfox01

tmccoy529 commented 5 years ago

@danfox01 we will do a hot fix on Monday for this. I'd like to have Marty around when I do this to make sure I don't do anything wrong and bring down prod.

danfox01 commented 5 years ago

@tmccoy529, haha I don't want that either. Let's touch base Monday morning and schedule a time to do this. I'll want @jdomasky available to test prod too. Thanks!

danfox01 commented 5 years ago

Hey gents, when do we want to tackle this release? If it's today, I want to make sure we get it in with enough time to allow @jdomasky to test.