search

bamlab / react-native-flipper-performance-monitor

An attempt to have a lighthouse for React Native. Flipper plugin to show a graph of the React Native performance monitor
MIT License
586 stars 17 forks source link

Expo support #40

Closed wtfabio closed 2 years ago

wtfabio commented 2 years ago

Just chiming in to ask about the feasability of adding Expo support to the package. I'm currently using Expo SDK 44, which supports native modules.

I'd be happy to help if you give me any pointers. Thanks!

Spoutnik97 commented 2 years ago

Hi! You can create an Expo plugin thanks to https://github.com/expo/config-plugins and Expo docs : https://docs.expo.dev/guides/config-plugins/

The main goal is to modify the native files (you get as a string) to the target files (as a string) with modifiers. These modifiers are generally string modifier thanks to regex It would be a pleasure to help you to create this plugin with you @fabio-alvarenga ;)

hirbod commented 2 years ago

@Spoutnik97 did you start working on this? Because I just promised on appjsconf that I will build a config plug-in for this - but not if someone else is already on it :)

Almouro commented 2 years ago

Hey @hirbod, yeah I confirm @Spoutnik97 didn't get a chance to implement it

By the way here are the new docs for the 0.68.0 installation on iOS https://github.com/bamlab/react-native-performance/pull/55/commits/1e7655ed59cc396967eb554fe58dd096dba981d9

hirbod commented 2 years ago

Thanks. That's easy. I'll finish the plug-in this week.