search

bamlab / react-native-flipper-performance-monitor

An attempt to have a lighthouse for React Native. Flipper plugin to show a graph of the React Native performance monitor
MIT License
584 stars 17 forks source link

React 17+ support #69

Closed hnqso closed 2 years ago

hnqso commented 2 years ago

Bonjour @Almouro, do you have any plans to support React 17 and 18? Merci

Almouro commented 2 years ago

Bom dia @hnqlv!

So far, the plugin is reporting FPS exclusively from the native side, so it supports RN apps with React 17 or React 18 Or do you mean support for web apps?

hnqso commented 2 years ago

@Almouro yea sorry, talking specifically about react-native-startup-trace package:

"peerDependencies": {
  "react": "^16.8.1"
}
Almouro commented 2 years ago

Oh right, should probably move that one into its own repo 😅 It should be compatible with both React 17 and React 18 for sure, I'll update the peer dependencies

hnqso commented 2 years ago

@Almouro great! I wanted to make sure before forcing the peer deps! 😆 Appreciate the fast response, cheers!