Closed MorenoMdz closed 1 year ago
Almouro
commented
1 year ago Hi @MorenoMdz, apologies for the delay answering!
Seems like a nasty one! 😅 What RN version are you using, and did you enable the new arch by any chance? Also are you able to reproduce on https://github.com/bamlab/react-native-flipper-performance-monitor/tree/master/example?
In the meantime, you can also experiment with this plugin which might be a little more inaccurate but doesn't require any installation
MorenoMdz
commented
1 year ago Hi @MorenoMdz, apologies for the delay answering!
Seems like a nasty one! 😅 What RN version are you using, and did you enable the new arch by any chance? Also are you able to reproduce on https://github.com/bamlab/react-native-flipper-performance-monitor/tree/master/example?
In the meantime, you can also experiment with this plugin which might be a little more inaccurate but doesn't require any installation
Hey Almouro!
I will get back to benchmarking our App later this week I will give your suggestions a try.
Our app is running on Expo SDK 46 and RN 0.69.6, Android is using Hermes and iOS is using jsc still.
Almouro
commented
1 year ago Hi @MorenoMdz, would you be able to try version 0.4.0-rc.0?
If you're building locally, you'll likely need to run expo prebuild --clean before building
I've also added an minimal expo example in here: https://github.com/bamlab/react-native-flipper-performance-monitor/tree/revert-expo-hack/expo-example with this new version if you want to try it out
MorenoMdz
commented
1 year ago Hi @MorenoMdz, would you be able to try version
0.4.0-rc.0?If you're building locally, you'll likely need to run
expo prebuild --cleanbefore buildingI've also added an minimal expo example in here: https://github.com/bamlab/react-native-flipper-performance-monitor/tree/revert-expo-hack/expo-example with this new version if you want to try it out
Sure I'll give it a try early next week, we had some build problems last week and had to revert the flipper install in our app, it was conflicting with some other plug-in. But I'll try again with this version
maxenceg
commented
1 year ago Hi @Almouro!
I had the crash before with version 0.3.1 each time I tried to click on "Start measuring".
I tried version 0.4.0-rc.0 as suggested and it's now working fine, thanks!
utpal-d4l
commented
1 year ago @maxenceg Is your project react native expo project?
utpal-d4l
commented
1 year ago Hi @Almouro! I am also facing a crash on 0.3.1. I have a non expo react native project.
I am getting these crashes.
FATAL EXCEPTION: main java.lang.NullPointerException: Attempt to invoke virtual method 'com.facebook.react.bridge.ReactContext com.facebook.react.ReactInstanceManager.getCurrentReactContext()' on a null object reference
Receiver stopMeasuring failed with error. Error: 'java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.modules.debug.FpsDebugFrameCallback.stop()' on a null object reference'.
I have also tried with version 0.2.1 and 0.4.0-rc.0 but no luck
react-native: 66.4
Flipper Client: 0.162.0
Hey there, first thank you very much for this tool very helpful overall.
We are trying to understand what could be causing our App to be very unresponsive lately, and so far I was able to run this plugin with Flipper just fine on the simulator, but on the Android emulator it always crashes as soon as I start the benchmark.
One of the crash reports:
Any ideas on what may be wrong here?
Thanks!