bamlab / react-native-flipper-performance-monitor

An attempt to have a lighthouse for React Native. Flipper plugin to show a graph of the React Native performance monitor
MIT License
588 stars 17 forks source link

Expo SDK 48 #84

Open jimmy123A opened 1 year ago

jimmy123A commented 1 year ago

The plugin is not working with the latest expo SDK. Are you able to fix, or anyone's up for a PR maybe?

jakobo commented 1 year ago

Hey there, maintainer of expo-community-flipper (an upstream dependency) here!

With SDK48, flipper is now officially supported. This means for SDK 48 you should remove the expo-community-flipper dependency and add expo-build-properties.

Most options carry over 1:1 under the new config object, including the ability to specify a semver version if you're using a version of react-native-flipper that differs from the one bundled with your react-native version. If after you've switched to the official build-properties plugin, things still aren't working, can you share the generated Podfile from expo prebuild? It's very helpful to ensure your Flipper is being defined properly when using an Expo setup.

danieldanielecki commented 1 year ago

I can confirm, after changing from expo-community-flipper to expo-build-properties it's working again.

Before I've seen an error I couldn't find in Google [ios.dangerous]: withIosDangerousBaseMod: Cannot add flipper arguments to the project's ios/Podfile. Please report this with a copy of your project Podfile. You can generate this with the expo prebuild command.

This issue can be closed.

danieldanielecki commented 1 year ago

PS. Code related to Flipper needs to be removed in AppDelegate.mm and in package.json. However, I couldn't find in the settings Start Measuring.

simulator_screenshot_ADBEA66B-FB75-4525-8CCA-0B102B5052E4

tamagutchi commented 1 year ago

PS. Code related to Flipper needs to be removed in AppDelegate.mm and in package.json. However, I couldn't find in the settings Start Measuring.

simulator_screenshot_ADBEA66B-FB75-4525-8CCA-0B102B5052E4

Same here. Any solutions regarding the missing Start Measuring option?