Allow multiple platforms to use docker image

banban525 / echonetlite2mqtt

ECHONET Lite to MQTT bridge.

MIT License

48 stars 7 forks source link

Allow multiple platforms to use docker image #27

Closed 386jp closed 12 months ago

386jp commented 1 year ago

This PR sets a platform variable in GitHub Action config for Docker image deployment. This allows people to use Docker image in arm-based system (like Asahi Linux), in addition to the amd-based system.

banban525 commented 1 year ago

Thank you for your PR. However, I'm not familiar with the "platforms" option. I'll merge it after a little research.

banban525 commented 12 months ago

@386jp

I understand the purpose of PR. When doing Docker pull in an Arm environment, an error occurs because arm64 is not specified.

However, reading some blogs, it seems that "docker/setup-qemu-action" is required for GitHub action to use "platforms". The current GitHub Action script does not have "docker/setup-qemu-action", which may cause the build to fail.

banban525 commented 12 months ago

@386jp

However, your suggestion to create a container image for arm64 is great. I'll merge this PR and debug it myself.