search

bartbutenaers / node-red-contrib-ui-svg

A Node-RED widget node to show interactive SVG (vector graphics) in the dashboard
Apache License 2.0
94 stars 27 forks source link

Not getting output from events since last update #105

Closed smcgann99 closed 2 years ago

smcgann99 commented 2 years ago

Bart,

Since last update none of my clickable icons are working. There is no output from svg node when they are clicked....

bartbutenaers commented 2 years ago

@smcgann99, Can you please provide a simple example flow? I have executed lots of tests for similar issues recently, but I got ZERO response on that. And on my call for beta testers, I got exactly the same amount of feedback... Bart

bartbutenaers commented 2 years ago

@smcgann99, This is caused by this error:

image

What happened:

  1. In the last release (2.3.0) the hardcoded CSS has been replaced by customizable CSS (in the new tabsheet).
  2. There was a bug in that code, so the Panzoom (and Hammer) scripts were loaded inside the CSS style tags.
  3. Since that failed, the $scope.init failed.
  4. As a result the next code was not being executed anymore, i.e. the event handlers were not applied anymore to your SVG shapes.

I have fixed this now on Github. Could you please install the version from Github (from within your .node-red folder):

npm install bartbutenaers/node-red-contrib-ui-svg

Could you please do some extra tests, and let me know if there are any other things not working anymore in your dashboard?

Thanks!! Bart

smcgann99 commented 2 years ago

It looks like thats fixed it Bart.

Many Thanks!

bartbutenaers commented 2 years ago

Hi @smcgann99, Thanks for the feedback! Glad to hear that it is solved. I will close this issue as soon as the new version is published on npm, to avoid that other users start posting duplicate issues... Would like to solve the issue with the dashboard colors first, before I create a new version. Bart

bartbutenaers commented 2 years ago

The fix has been published as version 2.3.1