bartbutenaers / node-red-contrib-ui-svg

A Node-RED widget node to show interactive SVG (vector graphics) in the dashboard
Apache License 2.0
94 stars 27 forks source link

Cannot set fill color for shapes since update to 2.3 #106

Closed Anka001 closed 2 years ago

Anka001 commented 2 years ago

Setting the color in the "fill style" tab does not work for shapes anymore. Fill color of shapes is always '#097479' (text color of dashboard?).

Applying the same settings to elements or icons does still work.

bartbutenaers commented 2 years ago

Hi @Anka001, Could you please check whether this is the same issue as this one?

Their solution is to remove the !important twice from the new CSS tabsheet. Could you please check whether that solves your issue?

And to give me some extra insights: could you remove those !important one by one, and let me know what happens in the different cases?

Thanks! Bart

Anka001 commented 2 years ago

Hi Bart,

thanks for the quick reply. The issue I raised is definitly related to the one you mentioned.

  1. Deleting the first „important“ (fill: currentColor !important;) did not help.
  2. Deleting the second (fill: inherit !important;) did the trick.

In my little test svg (just a shape, an element and an icon in different colors) this helped immediately.

In the more complex ‚productive‘ svg deleting „important“ did not work first time. I ended up deleting the shape, and creating it new. Worked as expected. Probably screwed up that shape while trying to work around the issue..

By the way: many thanks for creating this beautiful node. I never would have believed building an interactive floor plan can be as easy as this.

Regards,

Andreas

bartbutenaers commented 2 years ago

Hi Andreas,

Thanks for the quick and constructive answer! That info is very useful for me! And thanks for the kind words! Just what I needed after this release full of bugs...

I will close this issue as soon as the new version has been published, so other users with the same problem can find the workaround.

Bart

bartbutenaers commented 2 years ago

The fix has been published as version 2.3.1