Code beautifier - Githubissues

bartbutenaers / node-red-contrib-ui-svg

A Node-RED widget node to show interactive SVG (vector graphics) in the dashboard

Apache License 2.0

94 stars 27 forks source link

Closed bartbutenaers closed 5 years ago

bartbutenaers commented 5 years ago

As discussed with @Steve-Mcl we will introduce a code beautifier, for example this one.

Add it as a dependency to the package.json
Add a button below the SVG text input field
Automatically call it before the SVG text input field is being filled (e.g. when the third party editor content is being imported into the svg input field).

Steve-Mcl commented 5 years ago

Bart, the last point, I didn't do. My take on that was a user may not want or like the format generated by the prettyfier.

If you agree we can close this?

Steve-Mcl commented 5 years ago

Sorry, I misunderstood, the automatic option is for formatting AFTER popup editor.

I should be able to do that but my concern is if the formatter gets it wrong, it prevents us getting useful SVG out of the editor. Thoughts?

bartbutenaers commented 5 years ago

@Steve-Mcl , Perhaps you can add a checkbox "beautify code from svg editor" on our "Settings" tabsheet?

Steve-Mcl commented 5 years ago

Done, now in DEV branch