search

bartbutenaers / node-red-contrib-ui-svg

A Node-RED widget node to show interactive SVG (vector graphics) in the dashboard
Apache License 2.0
93 stars 27 forks source link

Overriding default jQuery UI styles and breaking the Node-RED Editor #56

Closed knolleary closed 4 years ago

knolleary commented 4 years ago

This node is overriding some jQuery UI styles which is breaking the Node-RED editor.

Specifically this line: https://github.com/bartbutenaers/node-red-contrib-ui-svg/blob/53fedabbdee73c088e96ceb88fb76a88b30c1d47/svg_graphics.html#L21

This gets applied to all dialogs in the editor, not just those the ui-svg node uses. The result being the Import/Export dialogs in the editor no longer look right.

Please use class names that are specific to your nodes to ensure any CSS you define only applies to your elements.

This applies to both the jquery classes but your other classes. It would be good if they were all prefixes with something like ui-svg-XYZ to minimise the chance of a naming collision.

Steve-Mcl commented 4 years ago

fixed in the panzoom branch (V2)

@bartbutenaers I'll leave it to you for merging / publshing. :)

bartbutenaers commented 4 years ago

Hi @knolleary, Version 1.2.3 is now published on npm. Hopefully the problem is solved now. If not, please reopen this issue. Bart