search

bates64 / papermario-dx

Base for Paper Mario romhacks
82 stars 26 forks source link

"Cannot load save from: New Mod" error after changing mod name in config.h #46

Open Wrymouth opened 7 months ago

Wrymouth commented 7 months ago

error message

After changing the name of my dx mod I get this error message on the title screen. The code below gives the impression that this is intended behaviour so that no save data from other mods is accidentally loaded, but it doesn't seem to account for the possibility that a modder might change the mod name themselves.

relevant code

bates64 commented 7 months ago

There should be a comment there explaining how to set up save data migrations

bates64 commented 7 months ago

You want something like

} else if (strcmp(saveData->modName, "New Mod") != 0) {
    ver_deserialize_idk_your_mod_save(saveData);
} else if ...
bates64 commented 7 months ago

Perhaps we can catch "New Mod" and have a specific error message that points to a guide on how to do save data migrations

bates64 commented 5 months ago

Let us know if https://github.com/bates64/papermario-dx/pull/66 fixes this / makes it more obvious what to do