bbc / hive-runner-android

Android module for Hive Runner
MIT License
6 stars 2 forks source link

Desired Capabilities from hive #61

Open Asimk21 opened 8 years ago

Asimk21 commented 8 years ago

There are some mandatory desired capabilities when we execute tests using appium on web browsers. It would be worth setting it in runner and then use that in scripts.

Following are mandatory capabilities

  1. PLATFORM_NAME (android or ios)
  2. DEVICE_NAME (name of device, it can be any string but it is mandatory)
  3. BROWSER_NAME (chrome or safari)

Also, we need to make sure that we have same capability names in ios-runner as well, so that same capabilities can be used and same test can execute on ios and android.

jonpwilson commented 8 years ago

It's starting to feel like we need to address the script types at last...

Currently, the script type (i.e. Android, iOS, Web Browser, etc) isn't passed by Hive Scheduler to the Runner and so selecting a script type has no bearing on how the script is run. We should change this so that the script type is passed which would then allow us to set any platform specific variables from within the runner.

Additionally, we should look at replacing the port allocation code currently found in the runner with the ability to request / reserve ports from within the script on Scheduler - that way we won't be using as many ports that are unnecessary for the current testing type (i.e. Charles proxy port for Appium tests)

jrmhaig commented 8 years ago

Part of bbc/hive-ci-bbc#34