search

bbc / hive-runner-android

Android module for Hive Runner
MIT License
6 stars 2 forks source link

Fixed the problem I was having with Device objects not being created,… #65

Closed wordswords closed 8 years ago

wordswords commented 8 years ago

… it was because the create_device wasn't being called on the hash array

jonpwilson commented 8 years ago

Additionally, just looking through the code; we have a @devices variable that's being used to store the list of devices from DeviceAPI. Each time this is called, the first thing the code does is to exclude the untrusted and devices with no permissions. Could we not exclude these when you're setting the variable? That way we lose a few select operations that would be unnecessary.