bbc / sqs-consumer

Build Amazon Simple Queue Service (SQS) based applications without the boilerplate
https://bbc.github.io/sqs-consumer/
Other
1.74k stars 333 forks source link

fix(consumer): Immediatly stop polling, abort current request #298

Closed yehor-manzhula closed 1 year ago

yehor-manzhula commented 2 years ago

Description

Stopping polling timeout and current polling request.

Motivation and Context

Stop method doesn't gracefully terminate polling:

  1. Stop method doesn't abort current polling request
  2. "Stopped" event emitted after polling timeout execution, that doesn't make any sense.

Actuall polling stop depends on: waitTimeSeconds + Messages processing time + pollingWaitTimeMs Multiple polls invoked

Types of changes

nicholasgriffintn commented 1 year ago

Closing this PR given the age and changes requested above, if you would still like to contribute please open a new PR, we may look into this separately as well.

github-actions[bot] commented 1 year ago

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.