Closed glennflanagan closed 1 year ago
I think really, handleMessage should just always reject with a proper error message, we definitely don't want to change our types here because of that, internally, we are always expecting an error to be an error, and would just external functions do the same.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.
Description
If handleMessage rejects with
undefined
ornull
thenemitError
will receive the same and will cause runtime error ofTypeError: Cannot read property 'name' of undefined
and will preventchangeVisibilityTimeout
from being called.Types of changes
Checklist: