search

bbc / sqs-consumer

Build Amazon Simple Queue Service (SQS) based applications without the boilerplate
https://bbc.github.io/sqs-consumer/
Other
1.74k stars 333 forks source link

Upgrade or remove `p-event` #330

Closed nicholasgriffintn closed 1 year ago

nicholasgriffintn commented 1 year ago

p-event breaks the Mocha tests when upgraded, this ticket is to look into why, if we can upgrade it, do that otherwise remove p-event from the tests.

nicholasgriffintn commented 1 year ago

Looks like p-event is now ESM only, so it would require that we also move to ESM, which I'm not sure if we want to do, looking at it 4.2.0 works just fine for our tests though, so this might not be a huge deal.

nicholasgriffintn commented 1 year ago

I think this works fine for now