bbc / sqs-consumer

Build Amazon Simple Queue Service (SQS) based applications without the boilerplate
https://bbc.github.io/sqs-consumer/
Other
1.71k stars 330 forks source link

fix: make the stop options optional #371

Closed dormesica closed 1 year ago

dormesica commented 1 year ago

Resolves #372

Description: Fixed the options parameter of consumer.stop to be optional (in the code it was treated as an optional parameter - here).

Type of change:

Why is this change required?: The option object is treated as required in the code but declared as required in the function's type.

Code changes:


Checklist:

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot CLA CHECK All Contributors have signed the CLA

nicholasgriffintn commented 1 year ago

Hey, this is completely correct, could I ask that you sign the CLA agreement please and then I can merge this in. You just have to write the comment as explained above ^.

dormesica commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

dormesica commented 1 year ago

@nicholasgriffintn I have posted the comment 😃

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 7f9e5c95 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 94.5% (0.0% change).

View more on Code Climate.