feat: support non-standard errors

bbc / sqs-consumer

Build Amazon Simple Queue Service (SQS) based applications without the boilerplate

https://bbc.github.io/sqs-consumer/

Other

1.71k stars 330 forks source link

feat: support non-standard errors #414

Closed aradbar closed 8 months ago

aradbar commented 12 months ago

Resolves #411 Support non-standard errors. Errors with a read only "message" raise - "Cannot set property message of X which has only a getter"

Description:

Allows the library to handle errors that have been thrown in non standard ways.

Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

Allows users to implement custom error handling solutions.

Code changes:

Adjusted the logic for error handling to use standardised functions toStandardError and toTimeoutError
Extends the formatted error with a cause containing the original error

codeclimate[bot] commented 12 months ago

Code Climate has analyzed commit ab1c57f4 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.2% (0.1% change).

View more on Code Climate.

mhuggins commented 9 months ago

Would love to see this land in the library! I just ran into this today and left a comment over here about how I had to work around it.

nicholasgriffintn commented 8 months ago

Sorry, this PR seems to have not been updated, as said previously, the tests appear to be passing but I would prefer the tests to be a little better, in particular, it's probably worth while adding E2E tests in for an implementation similar.

That said, this is probably fine as long as it actually solves the issue, I don't truly know as we don't have an example application for this issue.

mhuggins commented 7 months ago

Thank you!

github-actions[bot] commented 7 months ago

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.