bbc / sqs-consumer

Build Amazon Simple Queue Service (SQS) based applications without the boilerplate
https://bbc.github.io/sqs-consumer/
Other
1.71k stars 330 forks source link

feat: Add useQueueUrlAsEndpoint to ConsumerOptions #472

Closed mogu4iy closed 3 months ago

mogu4iy commented 3 months ago

Resolves #NUMBER

Description:

Add useQueueUrlAsEndpoint support in Consumer initialization

Type of change:

Why is this change required?:

Let use QueueUrl hostname as the endpoint with @aws-sdk/client-sqs@^v3.507.0

Code changes:

Add useQueueUrlAsEndpoint to ComsumerOptions, so it can be passed to SQSClient. Add useQueueUrlAsEndpoint check in Consumer constructor to pass true as default value.


Checklist:

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot CLA CHECK All Contributors have signed the CLA

mogu4iy commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

mogu4iy commented 3 months ago

@nicholasgriffintn I'd be happy if you check it ;)

codeclimate[bot] commented 3 months ago

Code Climate has analyzed commit 9a4db49c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.