Allow PaymentPlans weeks and duration be defined in seeds

[bcardiff]

Fixes #67 y elimina permite reemplazar los hacks en el código por datos. Se agrega documentación de la lógica.

Una vez que esto este integrado podemos eliminar las condiciones en el código 🎉

Saqué el price de los seeds porque sino se van a pisar en producción cuando se corra.

[manuelbicain]

Creo que entendí.

El jue, 21 abr 2022 a las 17:54, Brian J. Cardiff @.***>) escribió:

Fixes #67 https://github.com/bcardiff/themis/issues/67 y elimina permite reemplazar los hacks en el código por datos. Se agrega documentación de la lógica.

Una vez que esto este integrado podemos eliminar las condiciones en el código 🎉

Saqué el price de los seeds porque sino se van a pisar en producción cuando se corra.

You can view, comment on, or merge this pull request online at:

https://github.com/bcardiff/themis/pull/68 Commit Summary

• 86e0821 https://github.com/bcardiff/themis/pull/68/commits/86e0821c6c4353fa7f5f3e90be48621fa274a283 Add duration and deleted_at field to payment_plan
• 88cce02 https://github.com/bcardiff/themis/pull/68/commits/88cce027cfd6fbe2ae6063c7ded09e5b09eaba38 Update seeds for new fields
• 7d61d2f https://github.com/bcardiff/themis/pull/68/commits/7d61d2f2491ae1c9e8e21a6d6a73313c232b0fae Drop prices from seeds. They are updated via the UI in /admin/pricing
• e6177bf https://github.com/bcardiff/themis/pull/68/commits/e6177bf7e4bfde4ac2ffe67a2f8c3d657bae2fb2 Hide deleted_at payment_plans on admin and cashier
• 3eb8d6f https://github.com/bcardiff/themis/pull/68/commits/3eb8d6f247ee5ddf808264d34cf84068109c4e4c Add documentation for new fields
• ae3c0c7 https://github.com/bcardiff/themis/pull/68/commits/ae3c0c703acbc9d3c87a8525002d9b27ad6aec48 Remove unused code
• b2fa063 https://github.com/bcardiff/themis/pull/68/commits/b2fa06363135f777397f438fe1b744ef1d74ef00 Use single_class, due_date_months, weeks fields for duration logic
• c281439 https://github.com/bcardiff/themis/pull/68/commits/c28143926de787b7e146f2e19c2c6ed33e7d3396 Fix seeds
• 51285c1 https://github.com/bcardiff/themis/pull/68/commits/51285c194ed4d6c09eb3734302482ca6747febc8 Update docs

File Changes

(6 files https://github.com/bcardiff/themis/pull/68/files)

• M app/helpers/application_helper.rb https://github.com/bcardiff/themis/pull/68/files#diff-5f3fc5e3977d242572aa1d08551f5eb557de0ccaff30370838ee9df5386ea0da (2)
• M app/models/payment_plan.rb https://github.com/bcardiff/themis/pull/68/files#diff-7bf864d0717958458e1d0ac2864a3747e6dfe3589f8a1c6fc494f89dc231fd6d (37)
• M app/models/student_pack.rb https://github.com/bcardiff/themis/pull/68/files#diff-05a417817e1f43e6c7b5e915f1a39044e2842032c7cf9115e0923ab37430c5e6 (55)
• A db/migrate/20220419151044_add_duration_fields_to_payment_plans.rb https://github.com/bcardiff/themis/pull/68/files#diff-88eb8d0a8fd0e1788cddd1558ef3e69a068aac855f099b5b2bd89f89728399ac (9)
• M db/schema.rb https://github.com/bcardiff/themis/pull/68/files#diff-cbf8b25d6d853acf58fa9057841f407d29ffe90649c75cf9e3f51b2d6e3aa1d3 (23)
• M db/seeds.rb https://github.com/bcardiff/themis/pull/68/files#diff-c61a903a1201b0c7f076b0270377c20390c26f655ce63689d7d843296fcf63f3 (62)

Patch Links:

• https://github.com/bcardiff/themis/pull/68.patch
• https://github.com/bcardiff/themis/pull/68.diff

— Reply to this email directly, view it on GitHub https://github.com/bcardiff/themis/pull/68, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC72TLHV4756X7GMZ5PJPYDVGG6BRANCNFSM5UAMQMGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>