search

bcfoodapp / streetfoodlove

StreetFoodLove capstone project
3 stars 1 forks source link

Chart modification #446

Closed czhou578 closed 2 years ago

czhou578 commented 2 years ago

I made some changes to the charts.

Although for Chart 3, the first number that appears in the popup is representing the Month (from the code), but it looks a little bit confusing when in the chart (there is no context provided). Is this necessary? image

MakotoE commented 2 years ago

The title is for chart 3 includes "in the last month" so if we filtered by the last month, I don't think the month label is necessary.

czhou578 commented 2 years ago

Yeah, I agree. So that filter would just be on the frontend without changing the backend in any way right?

MakotoE commented 2 years ago

I think that is the best way given that we might want to be able to change the month.

czhou578 commented 2 years ago

Do you want users to be able to choose multiple months?

MakotoE commented 2 years ago

I think we should just do the previous month to make it easier.

czhou578 commented 2 years ago

Ok, yes that would be much easier.

czhou578 commented 2 years ago

I'm going to start a new PR for that filter. I messaged Silvia about the query with "distinct" in it. Can we approve this PR?