Different formatting for some variables?

bcgov / ExitSurveyAdmin

The Exit Survey Administration Tool will assist BC Stats in administering the BCPS Exit Survey.

https://www2.gov.bc.ca/gov/content/data/statistics/government/employee-research/exit-survey

Apache License 2.0

3 stars 1 forks source link

Different formatting for some variables? #233

Closed aclowery closed 1 year ago

aclowery commented 1 year ago

In test, records that were imported from the existing production seem to be going through a data update similar to the following for certain blank fields, I've noticed Address2 and Phone. They are being updated to a space. It seems like an unnecessary update to make in an employee's timeline.

hangler commented 1 year ago

Hi @aclowery. I agree this might be a bit annoying. However, it's probably part of the switch from the CSV to PSA API.

Ideally, I'd prefer not to touch the code that does this comparison. I think it might be better to avoid adding extra rules that circumvent the data as delivered to us from the PSA API (or CSV). IMO it's better to just log it once and then move on going forward.

What do you think? Would it cause you undue issues with e.g. the data export...?

hangler commented 1 year ago

We discussed and determined this is OK for now. Maybe as a nice-to-have in the future.