clear now clears the date

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.

https://bcgov.github.io/bcrs-shared-components/

Apache License 2.0

3 stars 30 forks source link

clear now clears the date #105

Closed kialj876 closed 2 years ago

kialj876 commented 2 years ago

Signed-off-by: Kial Jinnah kialj876@gmail.com

Issue #: /bcgov/entity#10059

Description of changes:

tiny update to have the clear on the text field clear the date
test case

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 2 years ago

Please rebuild Storybook and check those files in.

kialj876 commented 2 years ago

Please rebuild Storybook and check those files in.

Sounds good. What does that do if there isn't a new storybook file? Is it to ensure the existing storybook suites contain the new code?

I updated the readme and took away the comment that says to only do the build for new features

severinbeauvais commented 2 years ago

What does that do if there isn't a new storybook file? Is it to ensure the existing storybook suites contain the new code?

Yes, since that becomes this (ie, global for the project):

I updated the readme and took away the comment that says to only do the build for new features

Sounds good.