Updated Contact Info Text

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.

https://bcgov.github.io/bcrs-shared-components/

Apache License 2.0

3 stars 30 forks source link

Updated Contact Info Text #110

Closed cameron-eyds closed 2 years ago

cameron-eyds commented 2 years ago

Issue #: /bcgov/entity#10687

Description of changes:

Updated Text content and layout to meet up to date designs
Updated Stories and unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

cameron-eyds commented 2 years ago

Code (and stories!) looks good. I just want to confirm this will look OK in other UIs that use this component.

Definitely. I have tested in Alterations, Corrections and Change Filings. Im not entirely sure if this is used anywhere else.

severinbeauvais commented 2 years ago

Code (and stories!) looks good. I just want to confirm this will look OK in other UIs that use this component.

Definitely. I have tested in Alterations, Corrections and Change Filings. Im not entirely sure if this is used anywhere else.

Dissolution filings use this component too. Please have a look and update import or whatever if needed.

cameron-eyds commented 2 years ago

Code (and stories!) looks good. I just want to confirm this will look OK in other UIs that use this component.

Definitely. I have tested in Alterations, Corrections and Change Filings. Im not entirely sure if this is used anywhere else.

Dissolution filings use this component too. Please have a look and update import or whatever if needed.

Sounds good, will do!