search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

Contact Info - Optional Phone Prop #111

Closed cameron-eyds closed 2 years ago

cameron-eyds commented 2 years ago

Issue #: /bcgov/entity#10687

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

cameron-eyds commented 2 years ago

Do you have a new story or test case for this new option?

Also, I wonder if there's a way in GH to delete all previous versions of a file? I'm thinking we don't need to keep any of the Storybook files before the current one.

For sure, will add another story. Being that it's a prop, it can also be toggled in any of the existing stories as well, a nice feature :)

*Updated

severinbeauvais commented 2 years ago

Also, I wonder if there's a way in GH to delete all previous versions of a file? I'm thinking we don't need to keep any of the Storybook files before the current one.

I found this: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-files-from-a-repositorys-history and this: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-a-file-that-was-added-in-an-earlier-commit

Next time one of us is working in this repo, we should remove all the old versions of the docs folder.

cameron-eyds commented 2 years ago

Also, I wonder if there's a way in GH to delete all previous versions of a file? I'm thinking we don't need to keep any of the Storybook files before the current one.

I found this: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-files-from-a-repositorys-history and this: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-a-file-that-was-added-in-an-earlier-commit

Next time one of us is working in this repo, we should remove all the old versions of the docs folder.

I didn't even notice this before, thanks! Will do, certain i'll be back in here very soon